docs(aria): add required 'value' to ngMenuItem jsdocs
#32440
Merged
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msmallest
requested review from
mmalerba and
tjshiu
and removed request for
a team
14 tasks
tjshiu
approved these changes
Dec 1, 2025
Member
|
Looks like this needs a rebase. |
msmallest
force-pushed
the
ngMenuItem-value
branch
from
284ddf5 to
7aaf3bc
Compare
Contributor
Author
|
@crisbeto rebased. I overthought the rebase a bit but I think I did it right. |
mmalerba
approved these changes
Jan 21, 2026
Contributor
|
This pr has some lint issues ✘ Invalid commit message |
msmallest
force-pushed
the
ngMenuItem-value
branch
from
7aaf3bc to
674b90d
Compare
msmallest
changed the title
'value' to ngMenuItem jsdocs'value' to ngMenuItem jsdocs
The `value` is a required input. Without it, `menu.ts` will say "Required input 'value' from directive MenuItem must be specified.
msmallest
force-pushed
the
ngMenuItem-value
branch
from
674b90d to
c9112ae
Compare
Contributor
Author
|
@tjshiu updated it to |
tjshiu
added
target: patch
tjshiu
pushed a commit
that referenced
this pull request
Jan 30, 2026
The `value` is a required input. Without it, `menu.ts` will say "Required input 'value' from directive MenuItem must be specified. (cherry picked from commit 80be4e6)
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
valueis a required input. Without it,menu.tswill throw the error "Required input 'value' from directive MenuItem must be specified."edit: associated PR for the adev docs which also had this same problem: angular/angular#65721